Add UnbakedModelDeserializer
#4321
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is load conditions the same thing as resource conditions? if so, https://github.com/FabricMC/fabric/blob/1.21.4/fabric-resource-conditions-api-v1/src/main/java/net/fabricmc/fabric/impl/resource/conditions/ResourceConditionsImpl.java#L66-L87 is the implentation. If a type is not specified, the resource is loaded as normal, as if all conditions passed |
|
Technici4n
reviewed
Dec 23, 2024
|
|
||
| import net.fabricmc.fabric.impl.client.model.loading.UnbakedModelDeserializerRegistry; | ||
|
|
||
| public interface UnbakedModelDeserializer { |
| return UnbakedModelDeserializerRegistry.deserialize(reader); | ||
| } | ||
|
|
||
| UnbakedModel deserialize(JsonObject jsonObject, JsonDeserializationContext context) throws RuntimeException; |
There was a problem hiding this comment.
Missing javadoc, especially with regards to the context.
| return UnbakedModelDeserializerRegistry.deserialize(reader); | ||
| } | ||
|
|
||
| UnbakedModel deserialize(JsonObject jsonObject, JsonDeserializationContext context) throws RuntimeException; |
There was a problem hiding this comment.
Why RuntimeException rather than a Gson one?
There was a problem hiding this comment.
It is acceptable for the deserializer to throw any RuntimeException, such as InvalidIdentifierException. The vanilla JsonUnbakedModel deserializer does that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the
UnbakedModelDeserializerinterface, which allows overriding the deserialization process of a JSON model file based on itsfabric:typeJSON key.Points to Discuss
elements,parent,textures,ambientocclusion,display,gui_light) be provided? If so, how?UnbakedModelDeserializerhave a method to retrieve itsIdentifierlikeCustomIngredientSerializerinstead of the ID being passed to theregistermethod directly?UnbakedModelDeserializerbe generic? It represents a "type" which can create instances, and such classes are almost always generic both in Fabric API and vanilla.TODO